Skip to content

build: move edge browser test to saucelabs #16985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 6, 2019

Conversation

devversion
Copy link
Member

Browserstack Edge is currently very flaky and we don't seem
to be able to fix the flakiness on our end. Recording and debugging
live browserstack instances doesn't seem to help and the behavior
of the browser seems cached. e.g. commit that sets up the MDC
theme for the tests is not reflected in the BrowserStack browser video.

All the test failures are not reproducible locally in Edge, nor do they
reproduce if the tests are executed through BrowserStack from the
local machine (following the CI steps locally).

Since we don't want to spend too much time on it, and Edge runs
extremely slow and flaky on BrowserStack anyway.. we move it
over to Saucelabs.

Browserstack Edge is currently very flaky and we don't seem
to be able to fix the flakiness on our end. Recording and debugging
live browserstack instances doesn't seem to help and the behavior
of the browser seems cached. e.g. commit that sets up the MDC
theme for the tests is not reflected in the BrowserStack browser video.

All the test failures are not reproducible locally in Edge, nor do they
reproduce if the tests are executed through BrowserStack from the
local machine (following the CI steps locally).

Since we don't want to spend too much time on it, and Edge runs
extremely slow and flaky on BrowserStack anyway.. we move it
over to Saucelabs.
@devversion devversion requested a review from a team as a code owner September 5, 2019 20:52
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 5, 2019
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devversion devversion added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Sep 5, 2019
@ngbot
Copy link

ngbot bot commented Sep 5, 2019

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "ci/circleci: ivy_test" is failing
    pending missing required labels: target: *

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added target: patch This PR is targeted for the next patch release pr: merge safe labels Sep 5, 2019
@jelbourn jelbourn merged commit 1972d8b into angular:master Sep 6, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants