build: add otp prompt to release tool #17035
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jelbourn
added
pr: merge safe
target: minor
googlebot
added
the
cla: yes
devversion
added
pr: lgtm
action: merge
devversion
reviewed
Sep 10, 2019
| @@ -123,8 +123,12 @@ class PublishReleaseTask extends BaseReleaseTask { | |||
| // the user to interactively confirm that the script should continue. | |||
| await this._promptConfirmReleasePublish(); | |||
|
|
|||
| // Prompt for the OTP right before publishing so that it doesn't expire while building the | |||
| // packages. | |||
| const npmOtp = await promptForNpmOtp(); | |||
There was a problem hiding this comment.
Optional: just something I noticed after approving. Maybe we should have a comment here saying that the OTP token is needed as NPM requires two-factor auth for each write to the registry.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.