select: fix maximum call stack size error and improve performance in multiple mode #17062
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes fix "Maximum call stack size exceeded" error when selecting lots of options by value (e.g. clicking on a button).
Also improve performance by checking which options have to be selected/deselected when a new value comes in. Currently
SelectionModel
is cleared and options are selected by one every timeselect
value changes. This leads to poor performance when there are many options.Fixes #12504