Skip to content

build: update to latest MDC version #17076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 18, 2019
Merged

Conversation

crisbeto
Copy link
Member

Updates to the latest alpha version of MDC which includes some of the changes we need for the progress bar. Also fixes a breaking change in the tab styles.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 13, 2019
@crisbeto crisbeto force-pushed the mdc-upgrade branch 2 times, most recently from 0514439 to d642f5e Compare September 13, 2019 20:05
@crisbeto crisbeto marked this pull request as ready for review September 13, 2019 20:16
@crisbeto crisbeto requested review from jelbourn, mmalerba and a team as code owners September 13, 2019 20:16
@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release labels Sep 13, 2019
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Sep 13, 2019
@mmalerba
Copy link
Contributor

I believe there were some breaking button changes that @andrewseguin mentioned, button might need some tweaks in this PR

@crisbeto crisbeto removed the action: merge The PR is ready for merge by the caretaker label Sep 13, 2019
@andrewseguin
Copy link
Contributor

This causes buttons to lose their height since we now need to use their density system I think

mhKjHYBJrGY

I think it's fine to submit and I'll work on making the fixes

Updates to the latest alpha version of MDC which includes some of the changes we need for the progress bar. Also fixes a breaking change in the tab styles.
@crisbeto
Copy link
Member Author

Pushed a fix for the button height.

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Sep 13, 2019
@andrewseguin
Copy link
Contributor

Great thanks

@jelbourn jelbourn merged commit c1776e1 into angular:master Sep 18, 2019
jelbourn pushed a commit to jelbourn/components that referenced this pull request Sep 24, 2019
Updates to the latest alpha version of MDC which includes some of the changes we need for the progress bar. Also fixes a breaking change in the tab styles.

(cherry picked from commit c1776e1)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants