feat(material-experimental): add test harness for form-field

[devversion]

No description provided.

[jelbourn]

A bit more concise?

const hostClass = await (await this.host()).getAttribute('class');
for (const palette of ['accent', 'warn']) {
  if (hostClass.includes(palette)) {
    return palette;
  }
}

return 'primary';

[devversion]

Sounds like a good idea.

[devversion]

I'll actually keep it like that as otherwise we'd need to handle more things (i.e. spaces to separate classes in the class attribute). The current implementation is quite reasonable but just looks weird due to the Promise all for concurrency.

[mmalerba]

You could maybe use getProperty('classList') for this, now that we have separate methods for attributes and properties

[jelbourn]

I don't follow what you mean by handing more things. Checking for the absence/presence of "accent" or "warn" is enough, no?

[devversion]

My thinking is that class can contain more classes and that just checking using includes is not working 100%. e.g. class attribute could be: custom-mat-accent mat-primary-field.

So we need to ensure that there is a space before/after the class we check for, or that it is at the start/end of the class attribute value. or just split the class attribute by space.. Surely these cases are extremely rare but I don't think there is a benefit in making these things less robust if we can just simply use the public robust hasClass methods.

The current implementation basically checks for existence of the theme classes. It just uses the intended APIs but unfortunately looks kind of dirty (to me at least)

[devversion]

@mmalerba @jelbourn Addressed feedback. please have another look.

[mmalerba]

Let's call it MatFormFieldControlHarness and have MatInputHarness and MatSelectHarness extend it as well. It might need to go in its own file & build rule to make that work though.

[devversion]

@mmalerba done. I had to introduce another nested entry-point so that default controls which are also referenced in the MatFormFieldHarness can import the base control harness without introducing a circular dependency. For public consumers there is no change. They can still import through form-field/testing.

[mmalerba]

You could maybe use getProperty('classList') for this, now that we have separate methods for attributes and properties

[devversion]

@mmalerba @jelbourn Addressed most of the feedback. The discussion for the getThemeColor is still open. let me know if I should change it or not. I don't feel too strong about it.

[jelbourn]

LGTM

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}