Skip to content

feat(material-experimental/mdc-snackbar): Add skeleton. #17161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2019

Conversation

opozo
Copy link
Contributor

@opozo opozo commented Sep 21, 2019

Create snackbar skeleton based on MDC Web

@opozo opozo requested review from jelbourn and a team as code owners September 21, 2019 03:04
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 21, 2019
@opozo
Copy link
Contributor Author

opozo commented Sep 21, 2019

@jelbourn Not sure if you want me to create a PR for each steps like is in the doc or just create a single PR with all the steps, let me know.

@jelbourn jelbourn requested a review from mmalerba September 23, 2019 18:17
@jelbourn
Copy link
Member

Separate steps are definitely better

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn
Copy link
Member

Go ahead and comment on this PR once you have all the CI stuff passing. Let me know if you need any help.

@opozo
Copy link
Contributor Author

opozo commented Nov 5, 2019

Go ahead and comment on this PR once you have all the CI stuff passing. Let me know if you need any help.

@jelbourn, just came back from vacation, all the CI stuff are now passing.

@opozo opozo changed the title MDC Snackbar Skeleton feat(material-experimental/mdc-snackbar): MDC Snackbar Skeleton Nov 5, 2019
@opozo opozo changed the title feat(material-experimental/mdc-snackbar): MDC Snackbar Skeleton feat(material-experimental/mdc-snackbar): Skeleton Nov 5, 2019
@opozo opozo changed the title feat(material-experimental/mdc-snackbar): Skeleton feat(material-experimental/mdc-snackbar): Add skeleton Nov 5, 2019
@opozo opozo changed the title feat(material-experimental/mdc-snackbar): Add skeleton feat(material-experimental/mdc-snackbar): Add skeleton. Nov 5, 2019
@opozo opozo force-pushed the mdc-snackbar-skeleton branch from 1463b17 to 2076785 Compare November 5, 2019 03:42
@jelbourn jelbourn added the target: patch This PR is targeted for the next patch release label Nov 18, 2019
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I also just got back from vacation

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Nov 18, 2019
@jelbourn jelbourn merged commit 6bda718 into angular:master Nov 18, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 19, 2019
@opozo opozo deleted the mdc-snackbar-skeleton branch December 19, 2019 00:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants