build: examples not working in dev app #17166
Conversation
crisbeto
added
P2
googlebot
added
the
cla: yes
crisbeto
force-pushed
the
dev-app-examples
branch
from
af3b7ea to
46d32b8
Compare
There was a problem hiding this comment.
The reason the cdk-experimental and material-experimental examples were under the the non-experimental package was that we don't need to handle more rollup globals in the examples. Though I agree that it is more clean to move them under {cdk,material}-experimental.
Also on a note: I don't think that any examples will be used by accident. We still need to explicitly wire them up in the docs.
Anyway, the change in general looks good, but it looks like you forgot the rollup globals for the examples in the packages.bzl. Can you add the ones for the experimental packages? otherwise the docs-content will be broken. Validation for these is planned in #17108.
Fixes a couple of issues related to examples in the dev app: 1. The path mappings for all the new example entry points (e.g. `@angular/material-examples/material/button`) weren't being configured in the System config which meant that any page that consumes any of the examples would break. These changes make it so that whenever we configure a new entry point we automatically configure its examples. 2. The `popover-edit` examples were placed under the stable `cdk` and `material` example packages which is incorrect, because `popover-edit` itself is still experimental. These changes add new `cdk-experimental` and `material-experimental` packages under `material-examples` for consistency with the rest of the repo and so that we don't end up accidentally publishing these examples.
crisbeto
force-pushed
the
dev-app-examples
branch
from
46d32b8 to
e316c34
Compare
|
Updated the Rollup globals to include the experimental packages. Also FWIW, what I meant with exposing something by accident is that if we decided in the future to just render out all available examples rather than maintaining the list manually. |
devversion
added
pr: lgtm
action: merge
| srcRunfilePath + '/' + pkgName + '/' + entryPoint; | ||
| packagesConfig[srcRunfilePath + '/' + pkgName + '/' + entryPoint] = {main: 'index.js'}; | ||
| } | ||
| var name = entryPoint ? pkgName + '/' + entryPoint : pkgName; |
There was a problem hiding this comment.
This certainly helps simplify things 👍
Fixes a couple of issues related to examples in the dev app: 1. The path mappings for all the new example entry points (e.g. `@angular/material-examples/material/button`) weren't being configured in the System config which meant that any page that consumes any of the examples would break. These changes make it so that whenever we configure a new entry point we automatically configure its examples. 2. The `popover-edit` examples were placed under the stable `cdk` and `material` example packages which is incorrect, because `popover-edit` itself is still experimental. These changes add new `cdk-experimental` and `material-experimental` packages under `material-examples` for consistency with the rest of the repo and so that we don't end up accidentally publishing these examples. (cherry picked from commit 0b72461)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fixes a couple of issues related to examples in the dev app:
@angular/material-examples/material/button) weren't being configured in the System config which meant that any page that consumes any of the examples would break. These changes make it so that whenever we configure a new entry point we automatically configure its examples.popover-editexamples were placed under the stablecdkandmaterialexample packages which is incorrect, becausepopover-edititself is still experimental. These changes add newcdk-experimentalandmaterial-experimentalpackages undermaterial-examplesfor consistency with the rest of the repo and so that we don't end up accidentally publishing these examples.