build: validate bazel rollup globals #17173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
devversion
requested review from
andrewseguin,
crisbeto,
jelbourn and
a team
as code owners
devversion
added
P2
devversion
force-pushed
the
build/rollup-globals-validation
branch
4 times, most recently
from
c4ed87d to
1cd823b
Compare
jelbourn
added
pr: lgtm
action: merge
devversion
force-pushed
the
build/rollup-globals-validation
branch
2 times, most recently
from
15a8f12 to
0ffe8f0
Compare
|
Rebased since the |
devversion
force-pushed
the
build/rollup-globals-validation
branch
from
0ffe8f0 to
461ceb9
Compare
We can't import individual files through the module name because: * We don't have these listed in the rollup globals * These imports will break in the Angular package (due to limitation in APF).
Apparently the rollup globals tslint rule did not check all files. Resuling in a few cases where the rollup globals were missing.
We currently need to also maintain a list of rollup globals for bazel. Since these globals are impacting the release output we need to check these somehow in order to be sure that we do not accidentally bundle other entry-points into an entry-point.
devversion
force-pushed
the
build/rollup-globals-validation
branch
from
461ceb9 to
e19092e
Compare
mmalerba
added
P1
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: to reduce too much changes to the gulp build system yet, the rollup globals tslint rule will remain for now.