Skip to content

fix(material-experimental/slider): incorrectly rendering extra background #17207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2019

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Sep 26, 2019

Currently the slider always has the mdc-slider--display-markers class which causes an extra background to be rendered on sliders without markers. Since it's incorrect, these changes only add the class when markers are supposed to be rendered.

For reference:
Screenshot at Sep 26 14-09-39

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 26, 2019
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent pr: merge safe target: patch This PR is targeted for the next patch release labels Sep 26, 2019
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Sep 27, 2019
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason it was done like that is that the slider foundation does not recognize that the track markers class has changed. So adding it always fixed it, but I didn't realize it resulted in an extra background all the time.

We should figure out how to fix that, because fixing it like that opens up another bug where tickInterval cannot be toggled dynamically if it is initially set to 0.

@devversion devversion removed the action: merge The PR is ready for merge by the caretaker label Sep 28, 2019
…ound

Currently the slider always has the `mdc-slider--display-markers` class which causes an extra background to be rendered on sliders without markers. Since it's incorrect, these changes only add the class when markers are supposed to be rendered.
@crisbeto crisbeto force-pushed the mdc-slider-background branch from bf52a2d to 43ba9d9 Compare September 28, 2019 10:57
@crisbeto
Copy link
Member Author

crisbeto commented Sep 28, 2019

Updated to also handle the scenario where the slider starts off without markers.

@devversion devversion added the action: merge The PR is ready for merge by the caretaker label Sep 28, 2019
@mmalerba mmalerba merged commit 7bee53f into angular:master Oct 1, 2019
mmalerba pushed a commit that referenced this pull request Oct 8, 2019
…ound (#17207)

Currently the slider always has the `mdc-slider--display-markers` class which causes an extra background to be rendered on sliders without markers. Since it's incorrect, these changes only add the class when markers are supposed to be rendered.

(cherry picked from commit 7bee53f)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants