-
Notifications
You must be signed in to change notification settings - Fork 6.8k
fix(material-experimental/slider): incorrectly rendering extra background #17207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason it was done like that is that the slider foundation does not recognize that the track markers class has changed. So adding it always fixed it, but I didn't realize it resulted in an extra background all the time.
We should figure out how to fix that, because fixing it like that opens up another bug where tickInterval
cannot be toggled dynamically if it is initially set to 0
.
…ound Currently the slider always has the `mdc-slider--display-markers` class which causes an extra background to be rendered on sliders without markers. Since it's incorrect, these changes only add the class when markers are supposed to be rendered.
bf52a2d
to
43ba9d9
Compare
Updated to also handle the scenario where the slider starts off without markers. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Currently the slider always has the
mdc-slider--display-markers
class which causes an extra background to be rendered on sliders without markers. Since it's incorrect, these changes only add the class when markers are supposed to be rendered.For reference:
