Skip to content

build: change alpha/beta prerelease options to "next" #17285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 3, 2019
Merged

build: change alpha/beta prerelease options to "next" #17285

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions tools/release/prompt/prerelease-labels.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
import {Version} from '../version-name/parse-version';

/** Inquirer choice for selecting an alpha pre-release label. */
const ALPHA_CHOICE = {value: 'alpha', name: 'Alpha pre-release'};

/** Inquirer choice for selecting an beta pre-release label. */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/** Inquirer choice for selecting an beta pre-release label. */
/** Inquirer choice for selecting a next pre-release label. */

const BETA_CHOICE = {value: 'beta', name: 'Beta pre-release'};
const NEXT_CHOICE = {value: 'next', name: '"Next"" pre-release'};

/** Inquirer choice for selecting a release candidate label. */
const RC_CHOICE = {value: 'rc', name: 'Release candidate'};
Expand All @@ -17,10 +15,8 @@ export function determineAllowedPrereleaseLabels(version: Version) {
const {prereleaseLabel} = version;

if (!prereleaseLabel) {
return [ALPHA_CHOICE, BETA_CHOICE, RC_CHOICE];
} else if (prereleaseLabel === 'alpha') {
return [BETA_CHOICE, RC_CHOICE];
} else if (prereleaseLabel === 'beta') {
return [NEXT_CHOICE, RC_CHOICE];
} else if (prereleaseLabel === 'next') {
return [RC_CHOICE];
}

Expand Down