-
Notifications
You must be signed in to change notification settings - Fork 6.8k
feat(tabs): add input to opt out of pagination #17409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tabs): add input to opt out of pagination #17409
Conversation
Setting this to P2 because it's required for AIO. cc @gkalpak |
943afd1
to
98d4e80
Compare
The feedback has been addressed @jelbourn. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Could you change this to use coerceBooleanProperty
in a follow-up?
Currently the tabs pagination works automatically by measuring the size of the tab header to figure out whether to show pagination. This measuring can be expensive because it triggers a page layout and might not necessarily be required if the page won't have enough tabs to paginate through. These changes add an input and an option to the injection token to allow consumers to opt out of the pagination, if they know that they won't need it. Fixes angular#17317.
98d4e80
to
23ac073
Compare
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Currently the tabs pagination works automatically by measuring the size of the tab header to figure out whether to show pagination. This measuring can be expensive because it triggers a page layout and might not necessarily be required if the page won't have enough tabs to paginate through.
These changes add an input and an option to the injection token to allow consumers to opt out of the pagination, if they know that they won't need it.
Fixes #17317.