refactor: ensure hammer migration properly sets up gesture config in app module #17429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… module Currently the HammerJS v9 migration relies on a few utilities from `@schematics/angular`. Apparently these are not reliable enough for our migration use-case, so we cannot use them. This came up when testing the migration with more possible scenarios in the docs app. Currently the migration is unable to set up the gesture config (if hammer is used) in the app module if the bootstrap module call imports it through multiple layers of files. We can fix this, make the logic more robust and make the code less verbose by simply using the type checker to resolve the file that contains the app module references in a bootstrap call (that way we do not need to deal with import resolution).
devversion
added
P1
googlebot
added
the
cla: yes
devversion
changed the title
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the HammerJS v9 migration relies on a few utilities from
@schematics/angular. Apparently these are not reliable enough forour migration use-case, so we cannot use them.
This came up when testing the migration with more possible
scenarios in the docs app. Currently the migration is unable
to set up the gesture config (if hammer is used) in the app
module if the bootstrap module call imports it through multiple
layers of files. We can fix this, make the logic more robust and
make the code less verbose by simply using the type checker to
resolve the file that contains the app module references in a
bootstrap call (that way we do not need to deal with import resolution).