build: add lint rules banning new-ing of Object, String, Number and Boolean

[josephperrott]

No description provided.

[devversion]

What's the motivation of doing that? I somehow feel unhappy that we need to bring a whole new set of litn rules int our repo for that 😞

[josephperrott]

The same changes were just proposed for angular/angular and I wanted to create this to match.

The reason for doing the change is that there is no value brought from using these constructors, they all are less performant and/or more code than using the primitives directly.

In terms of having to bring in another set of lint rules, banning new Object isn't in the rules we already had, so I added the rules that we have in angular/angular

[jelbourn]

LGTM

[crisbeto]

I agree with @devversion that this seems redundant, considering that it hasn't come up before on this repo.

[jelbourn]

Is there a downside to having these? I don't see it ever coming up, but I don't see a cost to having them anyway

[devversion]

I don't mind much. I was mostly asking for the motivation of doing this. The downside is that we add more packages which aren't necessarily needed. Also FYI: lint rules like this, visit each identifier most likely and cause overall IDE slow-down (if implemented badly; just in general here).

[jelbourn]

That's fair. I personally turn off tslint in my IDE because it's waaaaay too aggressive while I'm in the middle of writing something. Like, I know the identifier is unused, I just wrote it 2 seconds ago.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}