refactor: hammer migration should add "HammerModule" if needed #17444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The v9 HammerJS migration should add the `HammerModule` to the app module if needed. Additionally if HammerJS is not used in templates (or in general), we remove references to the "HammerModule". This scenario can happen if someone updates to v9 Angular while keeping Angular Material v8. In that case, the author will add the `HammerModule` to the app module and whenever the update to v9+ Angular Material is performed, the `HammerModule` is not needed anymore.. so we can remove it automatically.
googlebot
added
the
cla: yes
devversion
added
pr: merge safe
target: major
devversion
commented
Oct 18, 2019
| @@ -235,6 +250,45 @@ export class HammerGesturesRule extends MigrationRule<null> { | |||
| }); | |||
| } | |||
|
|
|||
| /** Removes all references to the "HammerModule" from "@angular/platform-browser". */ | |||
| private _removeHammerModuleReferences() { | |||
There was a problem hiding this comment.
@jelbourn As I've shortly explained in the PR description, it will be a rare scenario that we need to remove the HammerModule, unless you can think of a different scenario?
if you think we should just not handle this case, I'm good with it. otherwise, it will be just that function that handles that scenario.
devversion
added
the
P1
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The v9 HammerJS migration should add the
HammerModuleto theapp module if needed.
Additionally if HammerJS is not used in templates (or in general),
we remove references to the "HammerModule". This scenario can happen
if someone updates to v9 Angular while keeping Angular Material v8. In
that case, the author will add the
HammerModuleto the app module andwhenever the update to v9+ Angular Material is performed, the
HammerModuleis not needed anymore.. so we can remove it automatically.