build: ensure angular version placeholder is up-to-date when staging release #17465
Conversation
…release Ensures that the Angular version placeholder is properly updated when staging the release. We perform this as part of the staging script, since changes between staging and publishing are *not* expected and this is enforced by the publish script. Additionally, the rules are very strict. If something ever changes due to unknown reasons, the peer dependency checks needs to be disabled manually / or updated.
googlebot
added
the
cla: yes
devversion
changed the title
| } | ||
|
|
||
| const configFileContent = readFileSync(bzlConfigPath, 'utf8'); | ||
| const matches = configFileContent.match(/ANGULAR_PACKAGE_VERSION = ["']([^"']+)/); |
There was a problem hiding this comment.
I do not know of a better way to get the version placeholder from the Bazel .bzl file.
There was a problem hiding this comment.
You could make a nodejs_binary that takes in the version placeholder as an argument and writes it to stdout or a genrule that outputs the placeholder to a file.
There was a problem hiding this comment.
Yeah, that's what we are doing for the rollup globals check (the genrule). Though it would complicate things if a file needs to be built by Bazel whenever the staging script runs. i.e. would we just spawn a process to build it?
The nodejs binary one is more interesting, but unfortunately it would complicate things too. If you remember, we used Bazel initially for the release scripts, but the scripts ran in the Bazel bin directory..
There was a problem hiding this comment.
For the genrule, yeah, that's what I had in mind (spawn a child process).
There was a problem hiding this comment.
Yeah, that would work. I don't mind much either. Happy to do the genrule if you slightly prefer it more than the other options. I'm somehow preferring the current one since we basically just need static analysis and actually building seems unnecessary. It's a more robust idea though.
devversion
added
pr: merge safe
target: patch
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Ensures that the Angular version placeholder is properly updated when
staging the release. We perform this as part of the staging script,
since changes between staging and publishing are not expected
and this is enforced by the publish script.
Additionally, the rules are very strict. If something ever changes
due to unknown reasons, the peer dependency checks needs to be
disabled manually / or updated.