feat(checkbox): add options defaults config #17473
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
andrewseguin
added
P2
…tion. Follow-up PR will add the same default options to the MDC component. BREAKING CHANGE: MAT_CHECKBOX_CLICK_ACTION is deprecated, use MAT_CHECKBOX_DEFAULT_OPTIONS
andrewseguin
force-pushed
the
checkbox-options
branch
from
ee2ce49 to
37b20e7
Compare
jelbourn
reviewed
Oct 24, 2019
| @@ -214,6 +231,9 @@ export class MatCheckbox extends _MatCheckboxMixinBase implements ControlValueAc | |||
| }); | |||
| } | |||
| }); | |||
|
|
|||
| // TODO: Remove this after the `_clickAction` parameter is removed as an injection parameter. | |||
| this._clickAction = this._clickAction || this._options.clickAction; | |||
There was a problem hiding this comment.
Since clickAction is deprecated, I think options.clickAction should take precedence
There was a problem hiding this comment.
Discussed in person - I think the way it is captures the most common use cases, especially since the options object is provided in root and always defined, so it's not easy to tell if the user is switched to it
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds injectable provider config to set the default color and click action.
Follow-up PR will add the same default options to the MDC component.
BREAKING CHANGES
MAT_CHECKBOX_CLICK_ACTIONis deprecated, useMAT_CHECKBOX_DEFAULT_OPTIONS