build: update node and yarn to latest stable versions #17474
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
devversion
force-pushed
the
build/update-yarn-node
branch
2 times, most recently
from
4e38a5e to
12f06d5
Compare
devversion
added
pr: merge safe
target: major
|
For reference: a few goldens had to be updated because the method overloads are now sorted based on their declaration order. This previously was not the case because |
josephperrott
requested changes
Oct 23, 2019
devversion
force-pushed
the
build/update-yarn-node
branch
2 times, most recently
from
e730954 to
d8d6785
Compare
|
@josephperrott Feedback addressed. Please have another look |
Some CI jobs currently fail because db283f1 removed Node v11 from the supported node versions. Some of CI jobs use Node V11 though, so they currently fail. e.g. https://circleci.com/gh/angular/components/89692. In order to fix this, we ensure that we use consistent versions. For Node, we use the current active LTS version (v12). And for Yarn, we use the latest stable yarn version.
devversion
force-pushed
the
build/update-yarn-node
branch
from
d8d6785 to
f0e5608
Compare
devversion
added
pr: lgtm
action: merge
|
How is requiring NodeJS 12 working with relation to the fact that Gulp 3 doesn't work with it? We're still on |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some CI jobs currently fail because db283f1 removed
Node v11 from the supported node versions. Some of CI jobs use Node v11 though, so they
currently fail. e.g. https://circleci.com/gh/angular/components/89692.
In order to fix this, we ensure that we use consistent versions. For Node, we use the current
active LTS version (v12). And for Yarn, we use the latest stable yarn version.