build: run tests against view engine and ivy #17491
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
devversion
force-pushed
the
build/cleanup-ivy-ci-tests
branch
3 times, most recently
from
2211afa to
8cb2490
Compare
We currently only run tests against Ivy due to the commit that switched the `--define=compile` flag. This means that the `ivy_test` and `local_browsers` job are doing the same. Instead we should change `ivy_test` to run tests against View Engine. Same applies for the cronjobs.
devversion
force-pushed
the
build/cleanup-ivy-ci-tests
branch
from
8cb2490 to
dda39e4
Compare
|
With this PR, it's also possible to switch between Ivy and View Engine easily by just passing Since it's temporary and reasonable that we default to Ivy bundles, I think it's fine like that. |
devversion
added
pr: merge safe
target: major
josephperrott
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently only run tests against Ivy due to the
commit that switched the
--define=compileflag.This means that the
ivy_testandlocal_browsersjobare doing the same. Instead we should change
ivy_testtorun tests against View Engine. Same applies for the cronjobs.