Skip to content

fix(material/chips): fix ripple element opacity when using CSS variable theming #17576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 10, 2019
Merged

fix(material/chips): fix ripple element opacity when using CSS variable theming #17576

merged 3 commits into from
Dec 10, 2019

Conversation

JoakimZebic
Copy link
Contributor

@JoakimZebic JoakimZebic commented Nov 1, 2019

Fixes a bug in the Angular Material chips component where ripple element doesn't have opacity when CSS variables are used to make a dynamic theme

Fixes #17577

@JoakimZebic JoakimZebic requested a review from jelbourn as a code owner November 1, 2019 19:40
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 1, 2019
@JoakimZebic JoakimZebic changed the title Fix mat-chips ripple element background (opacity) when using CSS variable theming fix(chips): fix ripple element background (opacity) when using CSS variable theming Nov 1, 2019
@JoakimZebic JoakimZebic changed the title fix(chips): fix ripple element background (opacity) when using CSS variable theming fix(chips): fix ripple element opacity when using CSS variable theming Nov 1, 2019
@JoakimZebic JoakimZebic changed the title fix(chips): fix ripple element opacity when using CSS variable theming fix(material/chips): fix ripple element opacity when using CSS variable theming Nov 1, 2019
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good, but some of the CI checks are failing.

@JoakimZebic
Copy link
Contributor Author

The changes look good, but some of the CI checks are failing.

Thanks for the review. I will take a look again at these tests, but I had some issues with executing them.

@crisbeto
Copy link
Member

crisbeto commented Nov 4, 2019

The test failures look like flakes so you should be able to resolve them by rebasing. The lint failure looks real though.

@JoakimZebic
Copy link
Contributor Author

Thank you.
Lint failure is some trailing whitespace (most likely). I will look into it. :)

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels Nov 4, 2019
@JoakimZebic
Copy link
Contributor Author

@googlebot I fixed it.

@crisbeto
Copy link
Member

crisbeto commented Nov 4, 2019

The CLA error is because you pushed the commits from two separate email addresses.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes PR author has agreed to Google's Contributor License Agreement and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels Nov 4, 2019
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent labels Nov 4, 2019
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba
Copy link
Contributor

It looks like similar changes got merged in #17649, we can either rebase this one and merge it to extract the separate mixin, or just close it.

@jelbourn @crisbeto

@jelbourn
Copy link
Member

jelbourn commented Dec 3, 2019

@JoakimZebic this passes Google's internal presubmit, just needs a rebase

@mmalerba
Copy link
Contributor

mmalerba commented Dec 3, 2019

@jelbourn I took care of it

@mmalerba mmalerba merged commit e7508ad into angular:master Dec 10, 2019
@JoakimZebic JoakimZebic deleted the fix-mat-chips-ripple-with-css-variable-theming branch December 10, 2019 07:10
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chips: Opacity is not added to the ripple element when using CSS variables to define a custom theme
5 participants