-
Notifications
You must be signed in to change notification settings - Fork 6.8k
fix(material/chips): fix ripple element opacity when using CSS variable theming #17576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(material/chips): fix ripple element opacity when using CSS variable theming #17576
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good, but some of the CI checks are failing.
Thanks for the review. I will take a look again at these tests, but I had some issues with executing them. |
The test failures look like flakes so you should be able to resolve them by rebasing. The lint failure looks real though. |
Thank you. |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
@googlebot I fixed it. |
The CLA error is because you pushed the commits from two separate email addresses. |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@JoakimZebic this passes Google's internal presubmit, just needs a rebase |
…S variables to define a custom theme
…S variables to define a custom theme
@jelbourn I took care of it |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fixes a bug in the Angular Material
chips
component where ripple element doesn't have opacity when CSS variables are used to make a dynamic themeFixes #17577