build: skip bazel mirror urls when fetching yarn and node #17606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bazel currently always tries to fetch Yarn and Node from the Bazel mirror server. This is not helpful since the mirror server usually does not contain artifacts for the versions we are requesting (this has been the case for a long time). Bazel currently always tries the mirror first, and falls back to the official URLs. We should just always use the official URLs. having the fallback seems to have no benefit since our other non-bazel jobs rely on the official URLS only too.
googlebot
added
the
cla: yes
josephperrott
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bazel currently always tries to fetch Yarn and Node from the
Bazel mirror server. This is not helpful since the mirror
server usually does not contain artifacts for the versions
we are requesting (this has been the case for a long time).
Bazel currently always tries the mirror first, and falls
back to the official URLs. We should just always use the
official URLs. having the fallback seems to have no benefit
since our other non-bazel jobs rely on the official URLS only too.
The goal is to not spend unnecessary time fetching stuff from the mirror
since we know it won't be available..