build: use genrule to generate example module #17615
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
devversion
added
blocked
devversion
force-pushed
the
build/get-rid-of-examples-module
branch
from
f13e741 to
97ac76b
Compare
devversion
commented
Nov 5, 2019
devversion
force-pushed
the
build/get-rid-of-examples-module
branch
2 times, most recently
from
b30e044 to
7042b92
Compare
devversion
removed
the
blocked
devversion
requested review from
andrewseguin,
jelbourn and
a team
as code owners
devversion
force-pushed
the
build/get-rid-of-examples-module
branch
from
7042b92 to
caf0cfe
Compare
Since we no longer use NGC for generating the package output of the examples, we can start using the genrule for the `ExampleModule` again. This means that we can fully remove the example module tasks from gulp. Additionally renames the `material-examples` package to `components-examples` and removes the `module.ts` workaround for the examples since we do not need a flat module index file with ngtsc.
devversion
force-pushed
the
build/get-rid-of-examples-module
branch
from
caf0cfe to
5181897
Compare
jelbourn
added
merge: caretaker note
|
Caretaker note: the docs-site will need a corresponding update |
Make glob less confusing
|
@devversion can you link a PR for the material.angular.io side changes so I can merge them together? |
|
There is no PR yet. I planned on doing the docs PR once this PR is merged and the docs content has been pushed to the docs-content repo. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we no longer use NGC for generating the package output
of the examples, we can start using the genrule for the
ExampleModuleagain.This means that we can fully remove the example module tasks from gulp. Additionally
renames the
material-examplespackage toexamplesand removes themodule.tsworkaround for the examples since we do not need a flat module index file with ngtsc.