refactor: switch acceptance members to type aliases #17653
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
added
blocked
devversion
requested review from
andrewseguin,
crisbeto,
jelbourn,
mmalerba and
a team
as code owners
googlebot
added
the
cla: yes
devversion
force-pushed
the
follow-up-coercion-inputs-acceptance-members
branch
from
3f4efd8 to
f1e70d5
Compare
devversion
added
action: merge
|
I need to rebase this PR, but will do after we released v9. I think at that point it will be easier to merge this PR. |
Instead of manually typing the union types for boolean and number inputs, we should use a type alias. This allows us to make changes easier in the future, and it avoids a lot of repetition.
mmalerba
force-pushed
the
follow-up-coercion-inputs-acceptance-members
branch
from
f1e70d5 to
1e395ed
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up PR to #17640. It has been told to me that #17640 already has a presubmit, so I submitted the type alias change as a separate PR. Happy to merge that into a single PR if we can easily get the new PR merged too.