perf(youtube-player): triggering change detection for unused events #17665
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the YouTube player component events all trigger change detection and are registered ahead of time, even if they aren't being used. These changes only set up the events if somebody is subscribed to them.
Also fixes a case where
first
was being used instead oftake(1)
. We want to avoidfirst
, because it'll throw if the observable completes before emitting.