Skip to content

build: delete rxjs d.ts files referencing rxjs-compat #17695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 20, 2019
Merged

build: delete rxjs d.ts files referencing rxjs-compat #17695

merged 1 commit into from
Nov 20, 2019

Conversation

josephperrott
Copy link
Member

From local testing moved build time of //src/material:npm_package from 182.22s. -> 97.95s.

@josephperrott josephperrott added pr: merge safe target: major This PR is targeted for the next major release labels Nov 13, 2019
@josephperrott josephperrott requested a review from a team as a code owner November 13, 2019 21:00
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 13, 2019
devversion
devversion approved these changes Nov 14, 2019
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Postinstall patches are so powerful (kinda like them at this point since they allow us to move forward way easier 😄 )

@devversion devversion added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Nov 14, 2019
@jelbourn jelbourn merged commit d77d668 into angular:master Nov 20, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 21, 2019
@josephperrott josephperrott deleted the rxjs-dts-file-removal branch March 20, 2020 22:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@josephperrott @devversion @jelbourn @googlebot