Skip to content

docs(harnesses): ensure all harnesses have complete and correct docs #17723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 22, 2019
Merged

docs(harnesses): ensure all harnesses have complete and correct docs #17723

merged 5 commits into from
Nov 22, 2019

Conversation

mmalerba
Copy link
Contributor

No description provided.

@mmalerba mmalerba added P2 The issue is important to a large percentage of users, with a workaround pr: merge safe labels Nov 15, 2019
@mmalerba mmalerba added this to the 9.0.0 milestone Nov 15, 2019
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 15, 2019
devversion
devversion reviewed Nov 15, 2019
View reviewed changes
@mmalerba mmalerba requested a review from a team as a code owner November 15, 2019 23:56
jelbourn
jelbourn reviewed Nov 18, 2019
View reviewed changes
devversion added a commit to devversion/material2 that referenced this pull request Nov 19, 2019
@devversion
build: set @returns description for void async methods automatically
85ca004 
Automatically sets the `@returns` tag description for asynchronous
methods which do not return any value.

This is a proposal based on the commit in:
angular#17723 (comment)
@devversion devversion mentioned this pull request Nov 19, 2019
Merged
devversion added a commit to devversion/material2 that referenced this pull request Nov 19, 2019
@devversion
build: set @returns description for void async methods automatically
80b9745 
Automatically sets the `@returns` tag description for asynchronous
methods which do not return any value.

This is a proposal based on the commit in:
angular#17723 (comment)
devversion added a commit to devversion/material2 that referenced this pull request Nov 19, 2019
@devversion
build: set @returns description for void async methods automatically
6093089 
Automatically sets the `@returns` tag description for asynchronous
methods which do not return any value.

This is a proposal based on the commit in:
angular#17723 (comment)
@mmalerba mmalerba added the target: patch This PR is targeted for the next patch release label Nov 19, 2019
jelbourn pushed a commit that referenced this pull request Nov 20, 2019
@devversion @jelbourn
build: set @returns description for void async methods automatically (#…
1512721 
…17751)

Automatically sets the `@returns` tag description for asynchronous
methods which do not return any value.

This is a proposal based on the commit in:
#17723 (comment)
@mmalerba
Copy link
Contributor Author

@jelbourn removed unnecessary @return and mentions of "promise for", should be ready to go now.

jelbourn
jelbourn approved these changes Nov 22, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Nov 22, 2019
@jelbourn jelbourn merged commit ef85134 into angular:master Nov 22, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion left review comments

@jelbourn jelbourn jelbourn approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

@crisbeto crisbeto Awaiting requested review from crisbeto

Assignees

@jelbourn jelbourn

@andrewseguin andrewseguin

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@mmalerba @jelbourn @devversion @googlebot @andrewseguin