refactor(ng-update): handle namespaced angular decorators in update-tool #17737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
added
P3
googlebot
added
the
cla: yes
Previously Angular did not support namespaced Angular decorators. e.g.
```
@core.Component({...})
@core.Directive({...})
```
Since this is now supported in ngtsc, we want to handle
such cases where stylesheets, templates are referenced in
namespaced decorators.
This can be achieved by moving the more advanced import
resolution logic made for the Hammer gesture migration
to the `cdk/update-tool`. Exposing these for other CDK
and Material migrations can be helpful anyway.
This also unveiled that we did not run non-misc test cases
automatically. This will be fixed as part of this commit.
…pdate-tool Address feedback
devversion
force-pushed
the
refactor/ng-update-handle-namespaced-imports
branch
from
c480255 to
ba01d63
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously Angular did not support namespaced Angular decorators. e.g.
Since this is now supported in ngtsc, we want to handle
such cases where stylesheets, templates are referenced in
namespaced decorators.
This can be achieved by moving the more advanced import
resolution logic made for the Hammer gesture migration
to the
cdk/update-tool. Exposing these for other CDKand Material migrations can be helpful anyway.
This also unveiled that we did not run non-misc test cases
automatically. This will be fixed as part of this commit.