build: add lint rule to avoid relative cross entry-point imports/exports #17741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
added
P1
devversion
requested review from
jelbourn,
mmalerba and
a team
as code owners
googlebot
added
the
cla: yes
|
I'm adding the P1 label since it improves the public API of the new CDK testing harness stuff, and currently we miss public types for Also it's generally good before we release final to be sure that we do not have any possibly breaking relative cross entry-point imports/exports. |
devversion
force-pushed
the
refactor/cdk-testing-fake-events
branch
3 times, most recently
from
d68e67c to
183ff02
Compare
jelbourn
added
pr: lgtm
action: merge
devversion
force-pushed
the
refactor/cdk-testing-fake-events
branch
from
183ff02 to
2c13425
Compare
Adds a new lint rule to avoid relative cross entry-point imports and exports. If a public entry-point imports from another entry-point it should use the public module name in order to comply with the Angular Package format, and to avoid unnecessary code inlining when creating flat entry-point bundles. Restructures the cdk testing fake-event code into `cdk/testing/testbed` since that is where the fake event code is primarily used. This makes the new lint rule happy, and also improves the public API of `cdk/testing` since interfaces like `ElementDimensions` are part of the `TestElement` class and should therefore be exported.
devversion
force-pushed
the
refactor/cdk-testing-fake-events
branch
from
2c13425 to
1b2a168
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new lint rule to avoid relative cross entry-point imports
and exports. If a public entry-point imports from another entry-point
it should use the public module name in order to comply with the
Angular Package format, and to avoid unnecessary code inlining when
creating flat entry-point bundles.
Restructures the cdk testing fake-event code into
cdk/testing/testbedsince that is where the fake event code is primarily used. This
makes the new lint rule happy, and also improves the public API
of
cdk/testingsince interfaces likeElementDimensionsarepart of the
TestElementclass and should therefore be exported.