refactor: handle stubbed window in SSR checks #17755
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
googlebot
added
the
cla: yes
Uses the `isPlatformBrowser` to check whether we're rendering on the server in the `google-maps` and `youtube-player` packages, similarly to what we're doing in the CDK. This handles people stubbing out the `window`.
crisbeto
force-pushed
the
maps-player-ssr-checks
branch
from
2aa5aed to
76a2d2c
Compare
CaerusKaru
approved these changes
Nov 19, 2019
jelbourn
approved these changes
Nov 20, 2019
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on feedback from @CaerusKaru
Uses the
isPlatformBrowserto check whether we're rendering on the server in thegoogle-mapsandyoutube-playerpackages, similarly to what we're doing in the CDK. This handles people stubbing out thewindow.