build: fix missing amd module name for primary entry-point #17757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even though the primary entry-point of Angular Material is empty, it should still have an AMD module name (similar to the CDK). A good example is that consumers of Angular Material in a Bazel project can have the unnamed bundle as input of a target (like ts_devserver). RequireJS will then throw about an anonymous module. Fixes angular#17720
devversion
added
the
P2
googlebot
added
the
cla: yes
devversion
added
pr: merge safe
target: patch
This comment has been minimized.
This comment has been minimized.
googlebot
added
the
cla: yes
jelbourn
added
pr: lgtm
action: merge
jelbourn
added a commit
to jelbourn/components
that referenced
this pull request
Nov 21, 2019
…ngular#17757)" This reverts commit 49977f7. Reverting because this commit breaks the local build for the release packages. Will further investigate why, but for now we need to revert to unblock doing a release.
jelbourn
added a commit
that referenced
this pull request
Nov 21, 2019
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though the primary entry-point of Angular Material is empty,
it should still have an AMD module name (similar to the CDK).
A good example is that consumers of Angular Material in a Bazel
project can have the unnamed bundle as input of a target (like
ts_devserver). RequireJS will then throw about an anonymous
module.
Fixes #17720