Skip to content

docs: update readme and add FAQ #17814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 3, 2019
Merged

Conversation

jelbourn
Copy link
Member

  • Updates the readme to reflect the multi-package nature of the repo
  • Adds a Frequently Asked Questions page

@jelbourn jelbourn added docs This issue is related to documentation pr: merge safe target: patch This PR is targeted for the next patch release labels Nov 26, 2019
@jelbourn jelbourn requested a review from a team as a code owner November 26, 2019 01:46
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 26, 2019
Copy link
Contributor

@StephenFluin StephenFluin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some minor feedback, but this looks like a really positive change!

FAQ.md Outdated
resources to provide more hands-on support. We recommend using [StackOverflow][] and [Gitter][] for
more help.

## Why doesn't this project provide support for application layouts?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"repo" might be a better word. "project" has an unclear meaning

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done


## What's your relationship to [MDC Web][]?

MDC Web and Angular Material were created independently by two different teams inside Google.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do they need the history? Can we just explain the current status?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel that the one sentence of context helps convey how we got to this point.


#### High level stuff planned for Q4 2019 (Oct - Nov):
## High level work planned for Q4 2019 (Oct - Dec):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why give dates? Why not just say "Future plans"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've always listed what we're actively working on in the current quarter here. This isn't a target date, just a list of project we're spending time on.

* Remove dependency on HammerJS
* Finish remaining test harnesses for Angular Material components
* Continuing to create new, API-compatible versions of the Angular Material components backed by
MDC Web ([see @jelbourn's ng-conf talk](https://youtu.be/4EXQKP-Sihw?t=891)).
[MDC Web][] ([see @jelbourn's ng-conf talk](https://youtu.be/4EXQKP-Sihw?t=891)).
* New `@angular/google-maps` package
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs to be removed, right? It shipped!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was still part of this quarter, so I'm going to leave it until January

Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


#### High level stuff planned for Q4 2019 (Oct - Nov):
## High level work planned for Q4 2019 (Oct - Dec):
* Remove dependency on HammerJS
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is done already.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was still part of this quarter, so I'm going to leave it until January

Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

* Updates the readme to reflect the multi-package nature of the repo
* Adds a Frequently Asked Questions page
@jelbourn jelbourn merged commit f4d0c18 into angular:master Dec 3, 2019

For every pull request, we run a presubmit against Google's internal test suite. This includes tests
for all of the projects that use Angular CDK and Angular Material inside Google. As you might
imagine, this process can be slow. Once this presubmit passes, PRs can generally be merged quickly.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

slow -> time consuming, might be a better way of putting it 😄

For every pull request, we run a presubmit against Google's internal test suite. This includes tests
for all of the projects that use Angular CDK and Angular Material inside Google. As you might
imagine, this process can be slow. Once this presubmit passes, PRs can generally be merged quickly.
When tests fail, however, the team has to spend time investigating before the PR can be merged.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merged or an issue with the changes can be identified.

for all of the projects that use Angular CDK and Angular Material inside Google. As you might
imagine, this process can be slow. Once this presubmit passes, PRs can generally be merged quickly.
When tests fail, however, the team has to spend time investigating before the PR can be merged.
[Google uses a single monolithic code repository for its code, which everything at head][monorepo].
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with everything at head?


Like any software team, we have limited time and resources. On top of the work we do in this repo,
our team builds and maintains a smaller suite of Google-internal UI components and provides support
to product teams inside Google using our components. We do our best to balance our time between bug
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it would be good to note the scale of these component's use within Google. I think that people would appreciate this more if they knew that this meant supporting x-hundred or x-thousand different teams. Obviously the number would be rough, but giving some idea of the scale might be helpful.

## Can you help debug my app?

We can generally answer quick or straightforward questions. However, our team doesn't have the
resources to provide more hands-on support. We recommend using [StackOverflow][] and [Gitter][] for
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the forums also still considered a valid place for asking questions?

@Splaktar
Copy link
Contributor

Splaktar commented Dec 5, 2019

Sorry for the delay in taking a look at this. Overall it looks good!

@EatonZ
Copy link

EatonZ commented Dec 16, 2019

FYI, the FAQ link is missing.

@Splaktar
Copy link
Contributor

@EatonZ thank you, fixed in PR #17972.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants