Skip to content

fix(youtube-player): avoid setInterval change detection when player is created #17894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 6, 2019
Merged

fix(youtube-player): avoid setInterval change detection when player is created #17894

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions src/youtube-player/youtube-player.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ import {
OperatorFunction,
pipe,
Subject,
of,
} from 'rxjs';

import {
Expand Down Expand Up @@ -210,7 +211,7 @@ export class YouTubePlayer implements AfterViewInit, OnDestroy, OnInit {
const endSecondsObs = this._endSeconds.pipe(startWith(undefined));
const suggestedQualityObs = this._suggestedQuality.pipe(startWith(undefined));

/** An observable of the currently loaded player. */
// An observable of the currently loaded player.
const playerObs =
createPlayerObservable(
this._youtubeContainer,
Expand All @@ -219,6 +220,7 @@ export class YouTubePlayer implements AfterViewInit, OnDestroy, OnInit {
widthObs,
heightObs,
this.createEventsBoundInZone(),
this._ngZone
).pipe(waitUntilReady(), takeUntil(this._destroyed), publish());

// Set up side effects to bind inputs to the player.
Expand Down Expand Up @@ -480,6 +482,7 @@ function createPlayerObservable(
widthObs: Observable<number>,
heightObs: Observable<number>,
events: YT.Events,
ngZone: NgZone
): Observable<UninitializedPlayer | undefined> {

const playerOptions =
Expand All @@ -489,7 +492,7 @@ function createPlayerObservable(
map(([videoId, [width, height]]) => videoId ? ({videoId, width, height, events}) : undefined),
);

return combineLatest([youtubeContainer, playerOptions])
return combineLatest([youtubeContainer, playerOptions, of(ngZone)])
.pipe(
skipUntilRememberLatest(iframeApiAvailableObs),
scan(syncPlayerState, undefined),
Expand All @@ -507,7 +510,7 @@ function skipUntilRememberLatest<T>(notifier: Observable<boolean>): MonoTypeOper
/** Destroy the player if there are no options, or create the player if there are options. */
function syncPlayerState(
player: UninitializedPlayer | undefined,
[container, videoOptions]: [HTMLElement, YT.PlayerOptions | undefined],
[container, videoOptions, ngZone]: [HTMLElement, YT.PlayerOptions | undefined, NgZone],
): UninitializedPlayer | undefined {
if (!videoOptions) {
if (player) {
Expand All @@ -519,7 +522,10 @@ function syncPlayerState(
return player;
}

const newPlayer: UninitializedPlayer = new YT.Player(container, videoOptions);
// Important! We need to create the Player object outside of the `NgZone`, because it kicks
// off a 250ms setInterval which will continually trigger change detection if we don't.
const newPlayer: UninitializedPlayer =
ngZone.runOutsideAngular(() => new YT.Player(container, videoOptions));
// Bind videoId for future use.
newPlayer.videoId = videoOptions.videoId;
return newPlayer;
Expand Down