refactor: remove inherited coercion acceptance members #17911
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
added
blocked
devversion
requested review from
andrewseguin,
crisbeto,
jelbourn,
mmalerba and
a team
as code owners
googlebot
added
the
cla: yes
|
Is this blocked on a new Angular release? |
|
@jelbourn Yes. this PR is waiting for a new Angular release since the inheritance fix just landed yesterday. |
devversion
force-pushed
the
refactor/remove-unnecessary-acceptance-members
branch
from
9d6d2e3 to
6164428
Compare
devversion
removed
the
blocked
jelbourn
added
pr: lgtm
action: merge
|
@devversion needs rebase |
devversion
force-pushed
the
refactor/remove-unnecessary-acceptance-members
branch
2 times, most recently
from
ee48c0c to
926fea2
Compare
|
Done. |
devversion
force-pushed
the
refactor/remove-unnecessary-acceptance-members
branch
from
926fea2 to
fa9597a
Compare
|
@mmalerba I rebased this another time. It would be nice if we can get it in since it seems to easily need a rebase (due to a lot of golden changes) |
devversion
force-pushed
the
refactor/remove-unnecessary-acceptance-members
branch
2 times, most recently
from
806fd31 to
9e05f15
Compare
Previously Angular did not inherit coercion acceptance members until we submitted an issue on the framework side. This issue will be fixed with angular/angular#34296. In preparation for that change to land, this PR removes all unnecessary acceptance members and updates the lint rule to avoid future duplications (the rule is also used to make that refactoring)
devversion
force-pushed
the
refactor/remove-unnecessary-acceptance-members
branch
from
9e05f15 to
b317505
Compare
jelbourn
pushed a commit
that referenced
this pull request
Jan 22, 2020
Previously Angular did not inherit coercion acceptance members until we submitted an issue on the framework side. This issue will be fixed with angular/angular#34296. In preparation for that change to land, this PR removes all unnecessary acceptance members and updates the lint rule to avoid future duplications (the rule is also used to make that refactoring) (cherry picked from commit 7a6f763)
yifange
pushed a commit
to yifange/components
that referenced
this pull request
Jan 30, 2020
Previously Angular did not inherit coercion acceptance members until we submitted an issue on the framework side. This issue will be fixed with angular/angular#34296. In preparation for that change to land, this PR removes all unnecessary acceptance members and updates the lint rule to avoid future duplications (the rule is also used to make that refactoring)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously Angular did not inherit coercion acceptance members until we submitted an issue
on the framework side. This issue will be fixed with angular/angular#34296.
In preparation for that change to land, this PR removes all unnecessary acceptance members and
updates the lint rule to avoid future duplications (the rule is also used to make that refactoring)