refactor: fix ripple-renderer in TS3.7

[mprobst]

Another DOM style nullable issue.

[crisbeto]

LGTM, the CI failure looks like a flake. Marking as safe, because it doesn't change any runtime code or public-facing types.

[devversion]

LGTM. Wondering if we should just add a test job with TS 3.7 to catch such issues. Looks like ripple-render was not the only place (according to #17900)

[mprobst]

Paul: usually we transition to TypeScript version++ within a few weeks, so that might not be worth it for this instance. It might be useful if you intend to support the old version for a longer period of time. It might still pay off if you're looking to build generic infrastructure that could be useful for each language upgrade, not sure.

[devversion]

@mprobst Yeah that's fair. It shouldn't be much effort to have a job for that though. I don't know.. probably not a priority either.

[mprobst]

We generally only do the most conservative fix when doing language upgrades, otherwise we end up spending all our time fighting e.g. mocked tests that check for precise values. Your fix is appropriate though, I think. Maybe in a follow up PR?

[devversion]

Yeah totally reasonable. Sounds good to me. That helped understanding the process.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}