Skip to content

refactor(material): deprecate MAT_LABEL_GLOBAL_OPTIONS in favor of form-field global defaults #18017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

devversion
Copy link
Member

@devversion devversion commented Dec 20, 2019

As of version 9 of Angular Material, the MAT_LABEL_GLOBAL_OPTIONS
injection token is deprecated. The default floating label behavior
should be set through the MAT_FORM_FIELD_DEFAULT_OPTIONS token.

DEPRECATED: MAT_LABEL_GLOBAL_OPTIONS exported in
@angular/material/core is deprecated. Use MAT_FORM_FIELD_DEFAULT_OPTIONS
from @angular/material/form-field. Note that the property float is
now matching the input name floatLabel.

DEPRECATED: FloatLabelType exported in @angular/material/core is
deprecated. Import the symbol from @angular/material/from-field.

@devversion devversion added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Dec 20, 2019
@devversion devversion added this to the 9.0.0 milestone Dec 20, 2019
@devversion devversion requested a review from mmalerba as a code owner December 20, 2019 15:06
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 20, 2019
@devversion devversion force-pushed the refactor/deprecate-core-label-options branch from 094b4b9 to c0930f6 Compare December 31, 2019 12:55
…rm-field global options

As of Angular Material version 9, the `MAT_LABEL_GLOBAL_OPTIONS`
injection token is deprecated. The default floating label behavior
should be set through the `MAT_FORM_FIELD_DEFAULT_OPTIONS` token.

DEPRECATED: `MAT_LABEL_GLOBAL_OPTIONS` exported in
`@angular/material/core` is deprecated. Use `MAT_FORM_FIELD_DEFAULT_OPTIONS`
from `@angular/material/form-field`. Note that the property `float` is
now matching the input name `floatLabel`.

DEPRECATED: `FloatLabelType` exported in `@angular/material/core` is
deprecated. Import the symbol from `@angular/material/from-field`.
@devversion devversion force-pushed the refactor/deprecate-core-label-options branch from c0930f6 to 95dfc30 Compare December 31, 2019 14:27
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Dec 31, 2019
@mmalerba mmalerba merged commit bfdf323 into angular:master Jan 10, 2020
yifange pushed a commit to yifange/components that referenced this pull request Jan 30, 2020
…lar#18017)

As of Angular Material version 9, the `MAT_LABEL_GLOBAL_OPTIONS`
injection token is deprecated. The default floating label behavior
should be set through the `MAT_FORM_FIELD_DEFAULT_OPTIONS` token.

DEPRECATED: `MAT_LABEL_GLOBAL_OPTIONS` exported in
`@angular/material/core` is deprecated. Use `MAT_FORM_FIELD_DEFAULT_OPTIONS`
from `@angular/material/form-field`. Note that the property `float` is
now matching the input name `floatLabel`.

DEPRECATED: `FloatLabelType` exported in `@angular/material/core` is
deprecated. Import the symbol from `@angular/material/from-field`.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants