build: remove hard-coded karma systemjs config #18025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
devversion
force-pushed
the
build/share-systemjs-generated-config
branch
from
a3df418 to
9e21d6b
Compare
devversion
added
pr: merge safe
target: patch
jelbourn
approved these changes
Jan 14, 2020
Removes the hard-coded Karma SystemJS config in favor of a shared SystemJS config that is used by both the dev-app and the legacy unit tests. The config is generated through Bazel and leverages the entry-point/package configuration we need to main in Bazel. That way we only have one canonical place for package/entry-point configuration (the `config.bzl` files per package).
devversion
force-pushed
the
build/share-systemjs-generated-config
branch
from
9e21d6b to
b36c5e6
Compare
jelbourn
added
pr: lgtm
action: merge
|
@jelbourn I wanted to reply on the |
yifange
pushed a commit
to yifange/components
that referenced
this pull request
Jan 30, 2020
Removes the hard-coded Karma SystemJS config in favor of a shared SystemJS config that is used by both the dev-app and the legacy unit tests. The config is generated through Bazel and leverages the entry-point/package configuration we need to main in Bazel. That way we only have one canonical place for package/entry-point configuration (the `config.bzl` files per package).
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the hard-coded Karma SystemJS config in favor of a shared SystemJS
config that is used by both the dev-app and the legacy unit tests.
The config is generated through Bazel and leverages the
entry-point/package configuration we need to main in Bazel. That way we
only have one canonical place for package/entry-point configuration (the
config.bzlfiles per package).