Skip to content

fix(google-maps): support numbers for width/height of the map #18105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 10, 2020
Merged

fix(google-maps): support numbers for width/height of the map #18105

merged 1 commit into from
Jan 10, 2020

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Jan 5, 2020

Similarly to what we support in Material and the CDK, these changes allow for numbers to be passed in directly as the width and height of a map. This is more convenient if the dimensions are computed.

@crisbeto
fix(google-maps): support numbers for width/height of the map
e94b782 
Similarly to what we support in Material and the CDK, these changes allow for numbers to be passed in directly as the `width` and `height` of a map. This is more convenient if the dimensions are computed.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent pr: merge safe target: patch This PR is targeted for the next patch release labels Jan 5, 2020
@crisbeto crisbeto requested a review from a team as a code owner January 5, 2020 07:47
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 5, 2020
jelbourn
jelbourn approved these changes Jan 10, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jan 10, 2020
@mmalerba mmalerba merged commit 02c24ec into angular:master Jan 10, 2020
yifange pushed a commit to yifange/components that referenced this pull request Jan 30, 2020
@crisbeto @yifange
fix(google-maps): support numbers for width/height of the map (angula…
eb29547 
…r#18105)

Similarly to what we support in Material and the CDK, these changes allow for numbers to be passed in directly as the `width` and `height` of a map. This is more convenient if the dimensions are computed.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @jelbourn @googlebot @mmalerba