Skip to content

chore: remove outdated todo for docs-content build #18110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

devversion
Copy link
Member

Removes an outdated TODO and adds a new comment
that explains why the docs-content will be built in this job.

Removing the TODO for code health.

Removes an outdated TODO and adds a new comment
that explains why the docs-content will be built in this job.
@devversion devversion added pr: merge safe target: patch This PR is targeted for the next patch release labels Jan 6, 2020
@devversion devversion requested a review from a team as a code owner January 6, 2020 12:44
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 6, 2020
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jan 9, 2020
@mmalerba mmalerba merged commit efebc94 into angular:master Jan 10, 2020
yifange pushed a commit to yifange/components that referenced this pull request Jan 30, 2020
Removes an outdated TODO and adds a new comment
that explains why the docs-content will be built in this job.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants