Skip to content

refactor: default to agnostic ts type to schematics one #18133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 8, 2020
Merged

refactor: default to agnostic ts type to schematics one #18133

merged 1 commit into from
Jan 8, 2020

Conversation

filipesilva
Copy link
Contributor

@filipesilva filipesilva commented Jan 8, 2020 •
edited
Loading

Fixes TOOL-1261, necessary for TS 3.7 update.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 8, 2020
@filipesilva filipesilva changed the title refactor: default to agnostic ts type to schematics on refactor: default to agnostic ts type to schematics one Jan 8, 2020
devversion
devversion approved these changes Jan 8, 2020
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@devversion devversion added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jan 8, 2020
@jelbourn jelbourn added the target: major This PR is targeted for the next major release label Jan 8, 2020
@jelbourn
Copy link
Member

jelbourn commented Jan 8, 2020

@filipesilva lint shows trailing whitespace

@filipesilva
Copy link
Contributor Author

And I would have gotten away with it too if it wasn't for that meddling lint!!

Splaktar
Splaktar approved these changes Jan 8, 2020
View reviewed changes
Copy link
Contributor

@Splaktar Splaktar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Splaktar Splaktar added the P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful label Jan 8, 2020
@mmalerba mmalerba merged commit 9fa5a6e into angular:master Jan 8, 2020
yifange pushed a commit to yifange/components that referenced this pull request Jan 30, 2020
@filipesilva @yifange
refactor: default to agnostic ts type to schematics one (angular#18133)
4805ddf 
Fixes TOOL-1261, necessary for TS 3.7 update.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Splaktar Splaktar Splaktar approved these changes

@devversion devversion devversion approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@filipesilva @jelbourn @Splaktar @devversion @googlebot @mmalerba