refactor: move common date input logic into base class #18213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves the common logic for a date input into a base class and implements it for the range inputs.
crisbeto
added
P3
googlebot
added
the
cla: yes
mmalerba
reviewed
Jan 21, 2020
| @@ -97,59 +69,17 @@ export class MatDatepickerInputEvent<D> { | |||
| }, | |||
| exportAs: 'matDatepickerInput', | |||
| }) | |||
| export class MatDatepickerInput<D> implements ControlValueAccessor, OnDestroy, Validator { | |||
| export class MatDatepickerInput<D> extends MatDatepickerInputBase<D> { | |||
There was a problem hiding this comment.
Does this need an inputs section in the decorator spec? I noticed that the API goldens show some inputs being removed
There was a problem hiding this comment.
The inputs got transferred onto the base class, but since it's not exported through the public API it won't show up in the golden. I think the golden only generates code for the class' own fields.
There was a problem hiding this comment.
Ok, I assumed tests would be broken if those inputs actually got removed, but just wanted to double check.
mmalerba
approved these changes
Jan 21, 2020
mmalerba
added
pr: lgtm
action: merge
crisbeto
added a commit
that referenced
this pull request
Jan 24, 2020
Moves the common logic for a date input into a base class and implements it for the range inputs.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Jan 24, 2020
Moves the common logic for a date input into a base class and implements it for the range inputs.
crisbeto
added a commit
that referenced
this pull request
Jan 29, 2020
Moves the common logic for a date input into a base class and implements it for the range inputs.
crisbeto
added a commit
that referenced
this pull request
Feb 5, 2020
Moves the common logic for a date input into a base class and implements it for the range inputs.
crisbeto
added a commit
that referenced
this pull request
Feb 17, 2020
Moves the common logic for a date input into a base class and implements it for the range inputs.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Feb 17, 2020
Moves the common logic for a date input into a base class and implements it for the range inputs.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the common logic for a date input into a base class and implements it for the range inputs.