-
Notifications
You must be signed in to change notification settings - Fork 6.8k
chore: store dev-app dark/light theme state in localStorage #18218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9dac25b
to
09f0c5f
Compare
09f0c5f
to
bd17f9a
Compare
bd17f9a
to
61913b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once the comments are addressed.
I kind of agree with Kristiyan, who proposed that we just have the code in the same class DevAppLayout
(like before). I don't mind too much though.
61913b6
to
68cbd50
Compare
68cbd50
to
54daf9a
Compare
I've done this after merging in the latest changes and resolving merge conflicts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
(cherry picked from commit 0665d86)
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
It's a pain to debug components' dark theme when every time you make a change the site reloads and goes back to light theme. This just makes it remember the previous value when the dev-app loads.