fix(drag-drop): error if next sibling is removed after drag sequence has started #18230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
googlebot
added
the
cla: yes
crisbeto
force-pushed
the
18205/drag-drop-sibling-remove
branch
from
f91b314 to
0aa1795
Compare
…has started When a drag sequence is started, we save a reference to the next sibling of the drag element so that we can use it at the end of the sequence to restore the element's original DOM position. This breaks down and throws an error if the next sibling gets removed while the user is dragging. These changes make the approach a bit more robust by inserting a comment node instead. Fixes angular#18205.
crisbeto
force-pushed
the
18205/drag-drop-sibling-remove
branch
from
0aa1795 to
037bb90
Compare
jelbourn
reviewed
Jan 25, 2020
| */ | ||
| private _nextSibling: Node | null; | ||
| private _anchor: Comment; |
There was a problem hiding this comment.
Could we do _placeholder instead of _anchor to avoid overload with <a>?
There was a problem hiding this comment.
We can't, because there's something different that we're calling a _placeholder already (the element shown in the place of the one you're dragging).
jelbourn
approved these changes
Jan 26, 2020
jelbourn
added
pr: lgtm
action: merge
jelbourn
pushed a commit
that referenced
this pull request
Jan 27, 2020
…has started (#18230) When a drag sequence is started, we save a reference to the next sibling of the drag element so that we can use it at the end of the sequence to restore the element's original DOM position. This breaks down and throws an error if the next sibling gets removed while the user is dragging. These changes make the approach a bit more robust by inserting a comment node instead. Fixes #18205. (cherry picked from commit d05c695)
yifange
pushed a commit
to yifange/components
that referenced
this pull request
Jan 30, 2020
…has started (angular#18230) When a drag sequence is started, we save a reference to the next sibling of the drag element so that we can use it at the end of the sequence to restore the element's original DOM position. This breaks down and throws an error if the next sibling gets removed while the user is dragging. These changes make the approach a bit more robust by inserting a comment node instead. Fixes angular#18205.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a drag sequence is started, we save a reference to the next sibling of the drag element so that we can use it at the end of the sequence to restore the element's original DOM position. This breaks down and throws an error if the next sibling gets removed while the user is dragging. These changes make the approach a bit more robust by inserting a comment node instead.
Fixes #18205.