Skip to content

build: remove unused angular bazel postinstall patch #18373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 4, 2020
Merged

build: remove unused angular bazel postinstall patch #18373

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
77 changes: 0 additions & 77 deletions tools/bazel/angular_bazel_rules_nodejs_1.0.0.patch
View file
Open in desktop

This file was deleted.

10 changes: 1 addition & 9 deletions tools/bazel/postinstall-patches.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ const fs = require('fs');
* Version of the post install patch. Needs to be incremented when
* existing patches or edits have been modified.
*/
const PATCH_VERSION = 3;
const PATCH_VERSION = 4;

/** Path to the project directory. */
const projectDir = path.join(__dirname, '../..');
Expand All @@ -29,14 +29,6 @@ shelljs.cd(projectDir);
// Workaround for https://github.com/angular/angular/issues/18810.
shelljs.exec('ngc -p angular-tsconfig.json');

try {
// Temporary patch to make @angular/bazel compatible with rules_nodejs 1.0.0.
// This is needed to resolve the dependency sandwich between angular components and
// repo framework. It can be removed with a future @angular/bazel update.
// try/catch needed for this the material CI tests to work in angular/repo
applyPatch(path.join(__dirname, './angular_bazel_rules_nodejs_1.0.0.patch'));
} catch (_) {}

// Workaround for https://github.com/angular/angular/issues/30586. It's not possible to
// enable tsickle decorator processing without enabling import rewriting to closure.
// This replacement allows us to enable decorator processing without rewriting imports.
Expand Down