feat(material-experimental/mdc-form-field): support for disabling animations #18397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
added
pr: merge safe
target: patch
googlebot
added
the
cla: yes
devversion
commented
Feb 5, 2020
| providers: Provider[] = [], | ||
| imports: any[] = [], | ||
| declarations: any[] = []): ComponentFixture<T> { | ||
| configureTestingModule(component, {providers, imports, declarations}); |
There was a problem hiding this comment.
Note that I intentionally kept the parameters for createComponent untouched. It's out of scope for this PR to refactor how tests create the component.
…mations By leveraging the animations feature target, we can add support for disabling animations of the form-field. Unlike in non experimental Material components, the class for toggling the animations is now scoped to the component. This gives more fine-grained control and makes it public. The class doesn't need to be denoted as private, as it can be useful for implementers of custom form-field controls. Also fixes that the line-ripple styles are not included.
devversion
force-pushed
the
feat/mdc-form-field-disable-animations
branch
from
51d063d to
ade2cf8
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By leveraging the animations feature target, we can add support for
disabling animations of the form-field. Unlike in non experimental
Material components, the class for toggling the animations is now
scoped to the component. This gives more fine-grained control and
makes it public. The class doesn't need to be denoted as private, as
it can be useful for implementer's of custom form-field controls.
Also fixes that the line-ripple styles are not included.