Skip to content

fix(cdk/text-field): fix autofill listener on Chrome 80 #18468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 20, 2020
Merged

fix(cdk/text-field): fix autofill listener on Chrome 80 #18468

merged 2 commits into from
Feb 20, 2020

Conversation

mmalerba
Copy link
Contributor

fixes #18461

@mmalerba mmalerba added P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release labels Feb 12, 2020
@mmalerba mmalerba requested a review from jelbourn February 12, 2020 00:13
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 12, 2020
@mmalerba
Copy link
Contributor Author

@jelbourn any objection to whitelisting s as a valid unit in stylelint?

crisbeto
crisbeto approved these changes Feb 12, 2020
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba requested a review from a team as a code owner February 12, 2020 19:39
jelbourn
jelbourn approved these changes Feb 12, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Feb 12, 2020
@andrewseguin andrewseguin merged commit 4b329f0 into angular:master Feb 20, 2020
andrewseguin pushed a commit that referenced this pull request Feb 20, 2020
@mmalerba @andrewseguin
fix(cdk/text-field): fix autofill listener on Chrome 80 (#18468)
8e43b48 
* fix(cdk/text-field): fix autofill listener on Chrome 80

* address feedback and fix lint

(cherry picked from commit 4b329f0)
@snyk-bot snyk-bot mentioned this pull request Mar 11, 2020
Merged
@snyk-bot snyk-bot mentioned this pull request Mar 21, 2020
Merged
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@crisbeto crisbeto crisbeto approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AutofillMonitor doesn't work after upgrading to Chrome 80
5 participants
@mmalerba @jelbourn @crisbeto @googlebot @andrewseguin