fix(ng-update): better detection for workspace project in v9 hammer migration #18525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
added
P3
googlebot
added
the
cla: yes
…igration Currently the v9 HammerJS migration determines the workspace project by consulting the `ts.Program` that has been constructed. This logic is not guaranteed to work because a TypeScript program doesn't necessarily need to contain any "root" file names. This means that we cannot reliably determine the workspace project from the `ts.Program` and we will throw an error that no project could be found. We can improve this logic by simply using the workspace project that is associated with the originating tsconfig file. This was previously not possible, but 411d048 enabled us to pass through the workspace project. Fixes angular#18504.
devversion
force-pushed
the
fix/ng-update-determine-proper-project
branch
from
f32c977 to
aeb443a
Compare
jelbourn
added
pr: lgtm
action: merge
jelbourn
pushed a commit
that referenced
this pull request
Feb 18, 2020
…igration (#18525) Currently the v9 HammerJS migration determines the workspace project by consulting the `ts.Program` that has been constructed. This logic is not guaranteed to work because a TypeScript program doesn't necessarily need to contain any "root" file names. This means that we cannot reliably determine the workspace project from the `ts.Program` and we will throw an error that no project could be found. We can improve this logic by simply using the workspace project that is associated with the originating tsconfig file. This was previously not possible, but 411d048 enabled us to pass through the workspace project. Fixes #18504. (cherry picked from commit c0c9f4a)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the v9 HammerJS migration determines the workspace project by
consulting the
ts.Programthat has been constructed. This logic is notguaranteed to work because a TypeScript program doesn't necessarily need
to contain any "root" file names. This means that we cannot reliably
determine the workspace project from the
ts.Programand we will throwan error that no project could be found.
We can improve this logic by simply using the workspace project that is
associated with the originating tsconfig file. This was previously not
possible, but 411d048 enabled us to pass through the workspace project.
Fixes #18504.