Skip to content

build: do not ship load-example code to npm package [patch port] #18554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 19, 2020
Merged

build: do not ship load-example code to npm package [patch port] #18554

merged 1 commit into from
Feb 19, 2020

Conversation

devversion
Copy link
Member

@devversion devversion commented Feb 19, 2020 •
edited
Loading

@googlebot

This comment has been minimized.

Sign in to view
@googlebot googlebot added the cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla label Feb 19, 2020
@devversion
build: do not ship load-example code to npm package (angular#18547)
7f49179 
We don't want to ship the `load-example` code that is internal to our
dev-app and e2e-app to the `@angular/components-examples` package.

The logic for loading examples lazily can never be generic enough to
work in all environments. i.e. in Webpack, such dynamic imports which
are not statically analyzable cannot be resolved. This could result in
errors being thrown by Webpack about critical dependencies.
@devversion devversion force-pushed the build/fix-9.0.x-branch-failures branch from 8968527 to 7f49179 Compare February 19, 2020 21:42
@googlebot

This comment has been minimized.

Sign in to view
@googlebot googlebot added cla: yes PR author has agreed to Google's Contributor License Agreement and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels Feb 19, 2020
@devversion devversion marked this pull request as ready for review February 19, 2020 21:52
@devversion devversion requested review from andrewseguin, jelbourn and a team as code owners February 19, 2020 21:52
@mmalerba mmalerba merged commit 0590af6 into angular:9.0.x Feb 19, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrewseguin andrewseguin Awaiting requested review from andrewseguin andrewseguin is a code owner

@jelbourn jelbourn Awaiting requested review from jelbourn jelbourn is a code owner

Assignees

@mmalerba mmalerba

Labels
cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@devversion @googlebot @mmalerba