Skip to content

build: remove browsersync snippet log #18566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2020

Conversation

crisbeto
Copy link
Member

After we disabled the server option in Browsersync, we started getting some extra logs which can be distracting. These changes remove the log.

After we disabled the `server` option in Browsersync, we started getting some extra logs which can be distracting. These changes remove the log.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent pr: merge safe target: patch This PR is targeted for the next patch release labels Feb 20, 2020
@crisbeto crisbeto requested a review from a team as a code owner February 20, 2020 21:36
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 20, 2020
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you try whether live-reloading still works?

Also did you notice that it doesn't print out the web server URL anymore?

@crisbeto
Copy link
Member Author

I tried out the livereloading and it still works. Also yes, I noticed that the URL isn't printed, but that's also because we turned off server.

@devversion devversion added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Feb 20, 2020
@jelbourn jelbourn merged commit 9262c63 into angular:master Feb 26, 2020
jelbourn pushed a commit that referenced this pull request Mar 3, 2020
After we disabled the `server` option in Browsersync, we started getting some extra logs which can be distracting. These changes remove the log.

(cherry picked from commit 9262c63)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants