fix(clipboard): not restoring focus to SVG elements #18626
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
googlebot
added
the
cla: yes
When the clipboard is copying something, focus is temporarily moved to a `textarea` and moved back. The logic that moves it checks whether the previous element was an `HTMLElement`, but that doesn't cover returning focus to an SVG element.
crisbeto
force-pushed
the
clipboard-svg-element-focus
branch
from
4d58576 to
1232f48
Compare
jelbourn
added
pr: lgtm
action: merge
andrewseguin
pushed a commit
that referenced
this pull request
Mar 12, 2020
When the clipboard is copying something, focus is temporarily moved to a `textarea` and moved back. The logic that moves it checks whether the previous element was an `HTMLElement`, but that doesn't cover returning focus to an SVG element. (cherry picked from commit ddc9fd6)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the clipboard is copying something, focus is temporarily moved to a
textareaand moved back. The logic that moves it checks whether the previous element was anHTMLElement, but that doesn't cover returning focus to an SVG element.