fix(material-experimental/mdc-list): fix styles for normal lists #18632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
reviewed
Feb 27, 2020
| @@ -8,3 +8,53 @@ | |||
| .mat-mdc-list-base { | |||
| display: block; | |||
| } | |||
|
|
|||
| // While MDC expects only span elements under mdc-list-item__text, we have historically supported | |||
There was a problem hiding this comment.
Do they have any examples where there's a header etc. outside mdc-list-item__text?
There was a problem hiding this comment.
|
FYI, fixed the avatar and divider issues |
Fixes up various styles for the lists under the "normal lists" section of the demo. There are still some issues around the avatars and dividers on the last list
|
@jelbourn updated the dev-app and examples to remove |
andrewseguin
pushed a commit
that referenced
this pull request
Mar 12, 2020
) * fix(material-experimental/mdc-list): fix styles for normal lists Fixes up various styles for the lists under the "normal lists" section of the demo. There are still some issues around the avatars and dividers on the last list * fix avatars and dividers * fix lint and api * address feedback (cherry picked from commit dd239dd)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes up various styles for the lists under the "normal lists" section of the demo.
Note: not merge-safe due to some minor changes in mat-line.
Demo: https://mmalerba-demo1.firebaseapp.com/mdc-list