fix(cdk/testing): don't send unnecessary Key.chords to protractor
#18685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
crisbeto
reviewed
Mar 3, 2020
Because of a bug in geckodriver (mozilla/geckodriver#1502), Key.chord does not work as expected when testing under Firefox. While there is no complete solution to that problem, this change at least reduces the frequency with which users will encounter the bug. Before: bug encountered on any invocation of sendKeys. After: bug only encountered when using modifier keys. Plain text can still be entered.
crisbeto
added
P3
mmalerba
added
G
devversion
approved these changes
Mar 3, 2020
mmalerba
added a commit
that referenced
this pull request
Mar 6, 2020
Because of a bug in geckodriver (mozilla/geckodriver#1502), Key.chord does not work as expected when testing under Firefox. While there is no complete solution to that problem, this change at least reduces the frequency with which users will encounter the bug. Before: bug encountered on any invocation of sendKeys. After: bug only encountered when using modifier keys. Plain text can still be entered.
This was referenced Mar 28, 2020
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of a bug in geckodriver (mozilla/geckodriver#1502), Key.chord does not work as expected when testing under Firefox. While there is no complete solution to that problem, this change at least reduces the frequency with which users will encounter the bug.
Before: bug encountered on any invocation of sendKeys.
After: bug only encountered when using modifier keys. Plain text can still be entered.